Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT-10352 upgraded saml library and updated tib version #341

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Oct 25, 2023

Description

Upgraded SAML library to fix CVE

Related Issue

TT-10352

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sweep-ai
Copy link

sweep-ai bot commented Oct 25, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sredxny sredxny merged commit 2ebc7ca into master Oct 25, 2023
9 checks passed
@sredxny sredxny deleted the TT-10352-upgrade-saml-dep branch October 25, 2023 15:59
@sredxny
Copy link
Contributor Author

sredxny commented Oct 25, 2023

/release to release-1.4

@tykbot
Copy link

tykbot bot commented Oct 25, 2023

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Oct 25, 2023
* upgraded saml library and updated tib version

* update crejam

(cherry picked from commit 2ebc7ca)
@tykbot
Copy link

tykbot bot commented Oct 25, 2023

@sredxny Succesfully merged PR

sredxny added a commit that referenced this pull request Oct 25, 2023
…b version (#341) (#342)

* TT-10352 upgraded saml library and updated tib version (#341)

* upgraded saml library and updated tib version

* update crejam

(cherry picked from commit 2ebc7ca)

* fix conflict

---------

Co-authored-by: Sredny M <sredny.buitrago@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants