Remove redundant check if label includes a certain key

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
TykTechnologies · Oct 18, 2023 · 3c7d27d · 3c7d27d
1 parent 88233a4
commit 3c7d27d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/predelete/predelete.go b/predelete/predelete.go
@@ -119,12 +119,8 @@ func PreDeleteBootstrappingJobs(clientset *kubernetes.Clientset) error {
 
 	var errCascading error
 	for _, job := range jobs.Items {
-		jobLabel, exists := job.ObjectMeta.Labels[constants.TykBootstrapLabel]
-		if !exists {
-			continue
-		}
-
 		// Do not need to delete pre-delete job. It will be deleted by Helm.
+		jobLabel := job.ObjectMeta.Labels[constants.TykBootstrapLabel]
 		if jobLabel != constants.TykBootstrapPreDeleteLabel {
 			deletePropagationType := metav1.DeletePropagationBackground
 

diff --git a/readiness/readiness.go b/readiness/readiness.go
@@ -61,7 +61,7 @@ func CheckIfRequiredDeploymentsAreReady() error {
 		if len(notReadyPods) == 0 {
 			return nil
 		}
-		
+
 		fmt.Printf("The following pods have containers that are NOT ready: ")
 		for pod, _ := range notReadyPods {
 			fmt.Println(pod)