Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resources field for kube-rbac-proxy container #360

Merged
merged 5 commits into from Sep 27, 2021
Merged

Conversation

cherrymu
Copy link
Contributor

@cherrymu cherrymu commented Sep 22, 2021

Description

Adding resource field in all.yaml file for kube-rbac-proxy container, so it gets the resources assigned to it.

Related Issue

fixes #359

Motivation and Context

This Change is required inorder to handle resourcequotas objects present in the namespace before deploying tyk-operator

Test Coverage For This Change

Tested this change locally on minikube environment and it works as expected.

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • [ x] Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor in applicable directories.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@gernest
Copy link
Contributor

gernest commented Sep 23, 2021

Thanks for the contribution.
Just wanted to let you know helm/templates/all.yaml is auto generated from kustomize+script so this is not where the changes should be.

The script to make changes on is https://github.com/TykTechnologies/tyk-operator/blob/master/hack/helm/pre_helm.go and you can run make helm to update the charts.

@cherrymu
Copy link
Contributor Author

Thank you very much for the guidance @gernest . Tested locally with recent commit changes and it is working as expected.

Copy link
Contributor

@gernest gernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gernest gernest merged commit 142eec7 into master Sep 27, 2021
@gernest gernest deleted the add-res-allyaml branch September 27, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator Pod Fails to come up when Resource Quotas are used in a namespace.
2 participants