Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint version to 1.50.1 #620

Merged
merged 1 commit into from
May 4, 2023

Conversation

buraksekili
Copy link
Member

@buraksekili buraksekili commented Apr 28, 2023

Description

golangci-lint was throwing panic in CI which causes failures even though there is no lining issue on the code. This PR updates golanci-lint version to fix this issue.

Reference: golangci/golangci-lint#3107 (comment)

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

Signed-off-by: Burak Sekili <buraksekili@gmail.com>
@buraksekili buraksekili marked this pull request as ready for review April 28, 2023 08:18
@buraksekili buraksekili requested a review from a team as a code owner April 28, 2023 08:18
@buraksekili buraksekili requested review from andrei-tyk and removed request for a team April 28, 2023 08:18
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@komalsukhani komalsukhani merged commit 7d47d12 into master May 4, 2023
14 checks passed
@komalsukhani komalsukhani deleted the update/golangci-lint-version branch May 4, 2023 06:29
buger pushed a commit that referenced this pull request May 22, 2024
Signed-off-by: Burak Sekili <buraksekili@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants