Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-10650] Upgrading golang/x/net to v0.17 #767

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[TT-10650] Upgrading golang/x/net to v0.17 #767

merged 2 commits into from
Jan 22, 2024

Conversation

mativm02
Copy link
Contributor

Description

In order to address CVE’s related to golang/x/net is required to upgrade to v0.17 in Pump.

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Jan 15, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

@buger
Copy link
Member

buger commented Jan 15, 2024 •
edited
Loading

API tests result - postgres15-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 19e3047 Upgrading golang/x/net to v0.17 (#767)
Triggered by: push (@mativm02)
Execution page

@buger
Copy link
Member

buger commented Jan 15, 2024 •
edited
Loading

API tests result - postgres15-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 19e3047 Upgrading golang/x/net to v0.17 (#767)
Triggered by: push (@mativm02)
Execution page

@buger
Copy link
Member

buger commented Jan 15, 2024 •
edited
Loading

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 19e3047 Upgrading golang/x/net to v0.17 (#767)
Triggered by: push (@mativm02)
Execution page

@buger
Copy link
Member

buger commented Jan 15, 2024 •
edited
Loading

API tests result - mongo44-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 19e3047 Upgrading golang/x/net to v0.17 (#767)
Triggered by: push (@mativm02)
Execution page

@sredxny sredxny self-requested a review January 15, 2024 15:18
@mativm02 mativm02 enabled auto-merge (squash) January 15, 2024 15:23
@mativm02 mativm02 merged commit 19e3047 into master Jan 22, 2024
22 checks passed
@mativm02 mativm02 deleted the TT-10650 branch January 22, 2024 08:58
@mativm02
Copy link
Contributor Author

mativm02 commented Mar 1, 2024

/release to release-1.9

@tykbot tykbot
Copy link

tykbot bot commented Mar 1, 2024

Working on it! Note that it can take a few minutes.

@buger buger mentioned this pull request Mar 1, 2024
Merged
@tykbot tykbot
Copy link

tykbot bot commented Mar 1, 2024

@mativm02 Succesfully merged PR

tykbot bot pushed a commit that referenced this pull request Mar 1, 2024
@mativm02
Upgrading golang/x/net to v0.17 (#767)
68aa34b 
(cherry picked from commit 19e3047)
mativm02 added a commit that referenced this pull request Mar 1, 2024
@buger @mativm02
Merging to release-1.9: Upgrading golang/x/net to v0.17 (#767) (#799)
ee0fce0 
* Upgrading golang/x/net to v0.17 (#767)

(cherry picked from commit 19e3047)

* Update go.mod

* Update go.sum

---------

Co-authored-by: Matias <matipvp02@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sredxny sredxny sredxny approved these changes

@tbuchaillot tbuchaillot tbuchaillot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mativm02 @buger @sredxny @tbuchaillot