Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-10409] Updating default Mongo driver to mongo-go #783

Merged
merged 5 commits into from
Jan 31, 2024
Merged

[TT-10409] Updating default Mongo driver to mongo-go #783

merged 5 commits into from
Jan 31, 2024

Conversation

mativm02
Copy link
Contributor

Description

Tyk v3/v4 does not work with MongoDB v5. Before Mongo DB 4.4 will get EOL by Feb 2024, so we are updating our default MongoDB driver to mongo-go from Tyk 5.3.

Related Issue

https://tyktech.atlassian.net/browse/TT-10409?atlOrigin=eyJpIjoiODdjODE2MTc4M2M1NGRiNmJkZWFhYmNjM2NlMjE1OWUiLCJwIjoiaiJ9

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Jan 29, 2024 •
edited
Loading

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed on d260290 (master) with the following error logs:

✨ Created Pull Request: #784

@buger
Copy link
Member

buger commented Jan 29, 2024 •
edited by jira bot
Loading

API tests result - postgres15-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 956b66a TT-10409 Updating default Mongo driver to mongo-go (#783)

  • Updating default Mongo driver to mongo-go

  • fixing TestDefaultDriver test

  • fixing TestDefaultDriver test

  • updating config comment

  • modifying config comment
    Triggered by: push (@mativm02)
    Execution page

@buger
Copy link
Member

buger commented Jan 29, 2024 •
edited by jira bot
Loading

API tests result - mongo44-sha256 env: success ✅
Branch used: refs/heads/master
Commit: 956b66a TT-10409 Updating default Mongo driver to mongo-go (#783)

  • Updating default Mongo driver to mongo-go

  • fixing TestDefaultDriver test

  • fixing TestDefaultDriver test

  • updating config comment

  • modifying config comment
    Triggered by: push (@mativm02)
    Execution page

@mativm02 mativm02 merged commit 956b66a into master Jan 31, 2024
22 checks passed
@mativm02 mativm02 deleted the TT-10409 branch January 31, 2024 12:54
@mativm02
Copy link
Contributor Author

/release to release-1.9

@tykbot tykbot
Copy link

tykbot bot commented Jan 31, 2024

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Jan 31, 2024
@mativm02
[TT-10409] Updating default Mongo driver to mongo-go (#783)
34f64e0 
* Updating default Mongo driver to mongo-go

* fixing TestDefaultDriver test

* fixing TestDefaultDriver test

* updating config comment

* modifying config comment

(cherry picked from commit 956b66a)
@buger buger mentioned this pull request Jan 31, 2024
Merged
@tykbot tykbot
Copy link

tykbot bot commented Jan 31, 2024

@mativm02 Succesfully merged PR

@buger
Copy link
Member

buger commented Jan 31, 2024 •
edited by jira bot
Loading

API tests result - mongo44-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 956b66a TT-10409 Updating default Mongo driver to mongo-go (#783)

  • Updating default Mongo driver to mongo-go

  • fixing TestDefaultDriver test

  • fixing TestDefaultDriver test

  • updating config comment

  • modifying config comment
    Triggered by: push (@mativm02)
    Execution page

@buger
Copy link
Member

buger commented Jan 31, 2024 •
edited by jira bot
Loading

API tests result - postgres15-murmur64 env: success ✅
Branch used: refs/heads/master
Commit: 956b66a TT-10409 Updating default Mongo driver to mongo-go (#783)

  • Updating default Mongo driver to mongo-go

  • fixing TestDefaultDriver test

  • fixing TestDefaultDriver test

  • updating config comment

  • modifying config comment
    Triggered by: push (@mativm02)
    Execution page

buger added a commit that referenced this pull request Jan 31, 2024
@buger
Merging to release-1.9: [TT-10409] Updating default Mongo driver to m…
999da0f 
…ongo-go (#783)

[TT-10409] Updating default Mongo driver to mongo-go (#783)

* Updating default Mongo driver to mongo-go

* fixing TestDefaultDriver test

* fixing TestDefaultDriver test

* updating config comment

* modifying config comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sredxny sredxny sredxny approved these changes

@tbuchaillot tbuchaillot Awaiting requested review from tbuchaillot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mativm02 @buger @sredxny