Skip to content

Commit

Permalink
[TT-7455] Delete golangci-lint github action (#4597)
Browse files Browse the repository at this point in the history
<!-- Provide a general summary of your changes in the Title above -->

## Description

This PR removes the duplicate/misconfigured golangci-lint github action.

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->
https://tyktech.atlassian.net/browse/TT-7455

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

Housekeeping GH actions:

1. We already have a golangci-lint action in ci-tests, which nicely
surfaces issues in sonarcloud,
2. Failure from GH action being removed doesn't produce file/line info
for errors (misconfiguration?)
3. Github Actions reuse (in future).

Removing this workflow doesn't hurt us, as we cover raising of errors in
CI Tests.


https://github.com/TykTechnologies/tyk/actions/runs/3795785568/jobs/6455252799#step:3:87

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [x] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

Co-authored-by: Tit Petric <tit@tyk.io>
  • Loading branch information
titpetric and Tit Petric committed Dec 29, 2022
1 parent fc6926e commit 913aba7
Showing 1 changed file with 0 additions and 32 deletions.
32 changes: 0 additions & 32 deletions .github/workflows/golangci-lint.yml

This file was deleted.

0 comments on commit 913aba7

Please sign in to comment.