Skip to content

Commit

Permalink
[TT-11762] fix nil err return (#6365)
Browse files Browse the repository at this point in the history
### **User description**
<!-- Provide a general summary of your changes in the Title above -->

## Description

Fix sonarcloud reported issue where err is returned when it is nil
## Related Issue
https://tyktech.atlassian.net/browse/TT-11762

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


___

### **PR Type**
Bug fix


___

### **Description**
- Fixed an issue where a nil error was incorrectly handled in the
`validateSignature` method within the `ProcessRequest` function in
`gateway/mw_auth_key.go`.


___



### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Bug fix
</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>mw_auth_key.go</strong><dd><code>Fix nil error check in
`validateSignature` method</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

gateway/mw_auth_key.go
<li>Fixed the condition to correctly handle non-nil errors in
<br><code>validateSignature</code>.<br>


</details>
    

  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/6365/files#diff-aeba053023a54c723dd9f83837e29ca0b2d9a212bc98fa6ad4bbb062669a1cf0">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>
</tr>                    
</table></td></tr></tr></tbody></table>

___

> 💡 **PR-Agent usage**:
>Comment `/help` on the PR to get a list of all available PR-Agent tools
and their descriptions
  • Loading branch information
jeffy-mathew committed Jun 20, 2024
1 parent 5d8cbd7 commit cadda82
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gateway/mw_auth_key.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func (k *AuthKey) ProcessRequest(_ http.ResponseWriter, r *http.Request, _ inter
if err == nil {
err, statusCode := k.validateSignature(r, keyID)
if err == nil {
return err, statusCode
return nil, statusCode
}
}

Expand Down

0 comments on commit cadda82

Please sign in to comment.