Clarify magic number

TykTechnologies · May 11, 2018 · cb3da3d · cb3da3d
1 parent 859e3fb
commit cb3da3d
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/middleware.go b/middleware.go
@@ -281,7 +281,13 @@ func (t BaseMiddleware) ApplyPolicies(key string, session *user.SessionState) er
 // CheckSessionAndIdentityForValidKey will check first the Session store for a valid key, if not found, it will try
 // the Auth Handler, if not found it will fail
 func (t BaseMiddleware) CheckSessionAndIdentityForValidKey(key string) (user.SessionState, bool) {
-	if len(key) <= t.Spec.GlobalConfig.MinTokenLength || len(key) <= 3 {
+	minLength := t.Spec.GlobalConfig.MinTokenLength
+	if minLength == 0 {
+		// See https://github.com/TykTechnologies/tyk/issues/1681
+		minLength = 3
+	}
+
+	if len(key) <= minLength {
 		return user.SessionState{IsInactive: true}, false
 	}