Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash logger panics when accessing Keys API #2250

Closed
buger opened this issue May 2, 2019 · 1 comment · Fixed by #2251
Closed

Logstash logger panics when accessing Keys API #2250

buger opened this issue May 2, 2019 · 1 comment · Fixed by #2251

Comments

@buger
Copy link
Member

buger commented May 2, 2019

Do you want to request a feature or report a bug?
bug
What is the current behavior?
Enabling logstash and querying /tyk/keys gives:

May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: 2019/05/02 11:48:24 http: panic serving 10.156.216.26:37498: interface conversion: error is *os.SyscallError, not syscall.Errno
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: goroutine 773111 [running]:
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: net/http.(*conn).serve.func1(0xc4206761e0)
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: /usr/local/go/src/net/http/server.go:1726 +0xd0
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: panic(0xdce0c0, 0xc42269be80)
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: /usr/local/go/src/runtime/panic.go:502 +0x229
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: github.com/TykTechnologies/tyk/vendor/github.com/netbrain/goautosocket.(*TCPClient).Write(0xc420095770, 0xc422be8000, 0x99, 0x10c, 0x0, 0x0, 0x0)
May 2 11:48:24 ovh-sb1udgtwf8 tyk-python: /src/github.com/TykTechnologies/tyk/vendor/github.com/netbrain/goautosocket/tcp_client.go:299 +0x3a5

What is the expected behavior?
It should not panic
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
See above
Which versions of Tyk affected by this issue? Did this work in previous versions of Tyk?
1.7.1 and higher

@buger
Copy link
Member Author

buger commented May 2, 2019

I've forked goautosocket library and fix error handling there https://github.com/TykTechnologies/goautosocket

buger added a commit that referenced this issue May 2, 2019
buger added a commit that referenced this issue May 2, 2019
buger added a commit that referenced this issue May 4, 2019
buger added a commit that referenced this issue May 14, 2019
buger added a commit that referenced this issue May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant