Merging to release-4.3: [TT-7455] Delete golangci-lint github action (#4597) #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API tests result: success ✅ |
<!-- Provide a general summary of your changes in the Title above --> ## Description This PR removes the duplicate/misconfigured golangci-lint github action. <!-- Describe your changes in detail --> ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> https://tyktech.atlassian.net/browse/TT-7455 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> Housekeeping GH actions: 1. We already have a golangci-lint action in ci-tests, which nicely surfaces issues in sonarcloud, 2. Failure from GH action being removed doesn't produce file/line info for errors (misconfiguration?) 3. Github Actions reuse (in future). Removing this workflow doesn't hurt us, as we cover raising of errors in CI Tests. https://github.com/TykTechnologies/tyk/actions/runs/3795785568/jobs/6455252799#step:3:87 ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why Co-authored-by: Tit Petric <tit@tyk.io> (cherry picked from commit 913aba7)
titpetric
force-pushed
the
merge/release-4.3/913aba766832d1868bfe7b4bc35d082f8bf018ae
branch
from
0ec669d
to
1eafa6a
Compare
💥 CI tests failed 🙈git-stateall okPlease look at the run or in the Checks tab. |
|
API tests result: success ✅ |
|
Kudos, SonarCloud Quality Gate passed!
|
titpetric
deleted the
merge/release-4.3/913aba766832d1868bfe7b4bc35d082f8bf018ae
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-7455 Delete golangci-lint github action (#4597)
Description
This PR removes the duplicate/misconfigured golangci-lint github action.
Related Issue
https://tyktech.atlassian.net/browse/TT-7455
Motivation and Context
Housekeeping GH actions:
surfaces issues in sonarcloud,
for errors (misconfiguration?)
Removing this workflow doesn't hurt us, as we cover raising of errors in
CI Tests.
https://github.com/TykTechnologies/tyk/actions/runs/3795785568/jobs/6455252799#step:3:87
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
functionality to change)
coverage to functionality)
Checklist
why it's required
explained why
Co-authored-by: Tit Petric tit@tyk.io