Virtual endpoint timeout #1490
Merged
Virtual endpoint timeout #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
buger
reviewed
Feb 21, 2018
mw_virtual_endpoint.go
Outdated
| @@ -153,11 +158,57 @@ func (d *VirtualEndpoint) ServeHTTPForCache(w http.ResponseWriter, r *http.Reque | |||
| return nil | |||
| } | |||
|
|
|||
| // Run the middleware | |||
| // vm := d.Spec.JSVM.VM.Copy() | |||
buger
pushed a commit
that referenced
this pull request
Feb 21, 2018
Add JSVM Timeout check to VirtualEndpoint.ServeHTTPForCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/TykTechnologies/tyk-analytics/issues/696
Code run in VirtualEndpoint now times out appropriately. Checking logic copied from https://github.com/TykTechnologies/tyk/blob/master/mw_js_plugin.go#L153
VirtualEndpoint middleware is now also run in a goroutine
Added Debug logs for jsvm timeout values