Fix panic caused by URL based versioning #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getVersionFromRequest` do not get in account `NotVersioned` flag, and UI by default writes `a.VersionDefinition.Location` field, so this check for version inside url was running for all non versioned APIs. In case of cloud it was causing panics, because nginx layer maps `slug` to `listenpath` and actual user URL does not contain listen path, and can be even smaller (which cause panic). Replaced manual array operation with `strings.TrimPrefix` which checks array bounds, and added support for stripping slug from URL too (for cloud case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getVersionFromRequestdo not get in accountNotVersionedflag, and UI by default writesa.VersionDefinition.Locationfield, so this check for version inside url was running for all non-versioned APIs.In case of cloud, it was causing panics, because nginx layer maps
slugtolistenpathand actual user URL does not contain listen path, and can be even smaller (which cause panic). Replaced manual array operation withstrings.TrimPrefixwhich checks array bounds, and added support for stripping slug from URL too (for cloud case).