Prepend apiid to path #1918
Closed
Prepend apiid to path #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblakeley
force-pushed
the
endpointpath
branch
from
c0b65b6
to
471b3b8
Compare
joshblakeley
force-pushed
the
endpointpath
branch
from
471b3b8
to
e50ecff
Compare
joshblakeley
changed the title
joshblakeley
force-pushed
the
endpointpath
branch
from
e50ecff
to
8fa2a35
Compare
joshblakeley
changed the title
|
We are back to just apiid again as using api name wouldnt be good due to it being possible to change over time - meaning records could become out of date with old names. |
|
@joshblakeley I just realized that probably better place for this code can be actually a Pump, and only mongo pumps. It should be more backward compatible, since if person already use ES pump or similar, they setup will be broken with this code. |
|
That sounds good to me. Not sure why we didnt think about that at this point. I'll close this and open pump PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #860
This make endpoints in aggregate become namespaced by apiid and path so endpoint popularity graphs will be fixed.
i.e. When record has
trackPath=truerecord.path becomes apiid/pathFirst path element before forward slash will always be apiid in aggregate collections.