moved RPC to rpc package #1922
Closed
moved RPC to rpc package #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cancelled by #1923 |
buger
pushed a commit
that referenced
this pull request
Oct 4, 2018
Another potentially better approach for TykTechnologies/tyk-pump#80 This approach allows to move some re-usable part of RPC without changing RPC server side. if it works then it cancels #1922 and TykTechnologies/tyk-sink#51 The idea is to do `rpc.Connect(...)` where we supply connection info, a couple of call backs for emergency mode and map of rpc funcs definitions to add to RPC client dispatcher. Then we can create `rpc.Purger` with all needed fields and run `PurgeLoop` with some ticker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to move RPC stack into new
rpcpackage which will be reused in context of TykTechnologies/tyk-pump#80There is some callback business and new function setupRPC() to glue
rpcpackage with globals in tyk.