Reuse client for heartbeat. #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblakeley
changed the title
|
I think that the fix is fine, but given that it is exactly same as my PR #1952 - better for @buger @dencoded @matiasinsaurralde to review |
|
Looks good! |
buger
pushed a commit
that referenced
this pull request
Nov 7, 2018
Fixes #1951 This prevents the issue with spawning a new open socket for each gateway to dashboard heartbeat that is observed in TLS connections when the default transport is overidden. From Go client.go: ``` // The Client's Transport typically has internal state (cached TCP // connections), so Clients should be reused instead of created as // needed. Clients are safe for concurrent use by multiple goroutines. ``` Since we are doing the same operation constantly it makes more sense to create a single client and reuse the connection for the dashboard heartbeat.
buger
pushed a commit
that referenced
this pull request
Nov 7, 2018
Fixes #1951 This prevents the issue with spawning a new open socket for each gateway to dashboard heartbeat that is observed in TLS connections when the default transport is overidden. From Go client.go: ``` // The Client's Transport typically has internal state (cached TCP // connections), so Clients should be reused instead of created as // needed. Clients are safe for concurrent use by multiple goroutines. ``` Since we are doing the same operation constantly it makes more sense to create a single client and reuse the connection for the dashboard heartbeat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1951
This prevents the issue with spawning a new open socket for each gateway to dashboard heartbeat that is observed in TLS connections when the default transport is overidden.
From Go client.go:
Since we are doing the same operation constantly it makes more sense to create a single client and reuse the connection for the dashboard heartbeat.