analytics RecordHit fixed #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a tricky code, so I decided to write a test (added to this branch). And while EOF error was solved, RawResponse field not get recorded when cache is used. |
|
Agree that it is tricky code, unfortunately I couldn't find better way to do a fix as the place when source Body buffer gets reset to len 0 is inside Go's standard library code. According to empty empty |
|
I will look into that PR changes with potentially another fix |
This reverts commit da90a42.
…cord RawResponse for cache hits
|
@buger PTAL |
|
Nice! So much clearer. |
buger
pushed a commit
that referenced
this pull request
Nov 29, 2018
added changes for #1996 Thus situation was happening when detailed analytics recording (copy of actual response in analytics record) is enabled. The code in RecordHit was screwing up copyResponse.Body underlaying buffer by reseting its length to 0. So item put into cache had only headers without body and it was causing that error `http: proxy error during body copy: unexpected EOF` as we use reverse-proxy code to instantiate response from cache item value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added changes for #1996
Thus situation was happening when detailed analytics recording (copy of actual response in analytics record) is enabled.
The code in RecordHit was screwing up copyResponse.Body underlaying buffer by reseting its length to 0. So item put into cache had only headers without body and it was causing that error
http: proxy error during body copy: unexpected EOFas we use reverse-proxy code to instantiate response from cache item value.