oauth-client check added in Oauth2KeyExists MW #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense |
|
Deleting all tokens is not an options, since their analytics data potentially can be useful. And we already have options to control expiration of oauth tokens. |
buger
pushed a commit
that referenced
this pull request
Feb 19, 2019
Added changes #2093 - check if oauth client is present in Redis - trying to avoid hitting Redis every time: - for deleted oauth client there will be only one hit, then result cached in memory cache - for not deleted oauth client result is cached for 1 sec Also, was exploring option just deleting all tokens at the time of oauth-client deletion but that might not work as sync call in case of big amount of issued tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes #2093
Also, was exploring option just deleting all tokens at the time of oauth-client deletion but that might not work as sync call in case of big amount of issued tokens.