update key endpoint changed #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buger
pushed a commit
that referenced
this pull request
Apr 15, 2019
added changes for TykTechnologies/tyk-analytics#996 The problem was because we were setting `quota_renews` to 0 when updating key with `suppress_reset=1` as it forces starting new quota renewal period (which equal to reseting quotas)
buger
pushed a commit
that referenced
this pull request
May 4, 2019
added changes for TykTechnologies/tyk-analytics#996 The problem was because we were setting `quota_renews` to 0 when updating key with `suppress_reset=1` as it forces starting new quota renewal period (which equal to reseting quotas)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added changes for https://github.com/TykTechnologies/tyk-analytics/issues/996
The problem was because we were setting
quota_renewsto 0 when updating key withsuppress_reset=1as it forces starting new quota renewal period (which equal to reseting quotas)