Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of WSDL import #2230

Merged
merged 12 commits into from
May 31, 2019
Merged

Added support of WSDL import #2230

merged 12 commits into from
May 31, 2019

Conversation

komalsukhani
Copy link
Contributor

@komalsukhani komalsukhani commented Apr 25, 2019

User can now import WSDL file to create API definition.
#Reference

Supported features:

  1. WSDL file with multiple services
  2. SOAP/SOAP12 binding
  3. HTTP binding

Generated API Definition will be as follows:

  1. API name is same as that of the service name. If WSDL contains multiple services, then the name of the first service in the file will be used.

  2. listen-path of the API will be

"/service name/"

If WSDL contains multiple services, then the name of the first service in the file will be used.

  1. For each supported operation, an endpoint will be created. Endpoint will have the path

/service_name/end_path

In case of SOAP/SOAP12 binding, end_path will be operation name.
In case of HTTP binding, end_path will be value of location attribute of the operation.

  1. Each endpoint will use url-rewrite middleware to direct the request to the upstream. This was necessary to support multiple services

If service has multiple Ports type, name of the Port needs to be specified. If Port name is not provided then first Port of the service is used.

#2255

Copy link
Contributor

@matiasinsaurralde matiasinsaurralde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

apidef/importer/wsdl.go Outdated Show resolved Hide resolved
apidef/importer/wsdl.go Outdated Show resolved Hide resolved
@buger
Copy link
Member

buger commented Apr 26, 2019

It definitely misses some tests, when it reads example WSDL file, and compare converted version with expected.

@buger buger force-pushed the feature/add-support-of-wsdl branch from 11c1e84 to 5bc2c5b Compare May 31, 2019 18:48
@buger buger merged commit e1466db into master May 31, 2019
@buger buger deleted the feature/add-support-of-wsdl branch May 31, 2019 18:49
@buger
Copy link
Member

buger commented May 31, 2019

@komalsukhani pls create UI related ticket

buger added a commit that referenced this pull request May 31, 2019
@komalsukhani
Copy link
Contributor Author

@buger Already created. Here is the link https://github.com/TykTechnologies/tyk-analytics-ui/issues/1182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants