Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webhook #2372

Merged
merged 6 commits into from
Jul 10, 2019
Merged

Fix webhook #2372

merged 6 commits into from
Jul 10, 2019

Conversation

komalsukhani
Copy link
Contributor

@komalsukhani komalsukhani commented Jul 3, 2019 •
edited by buger
Loading

  1. Added Timeout to HTTP client used for sending a request to webhook
  2. Added new flag useDefaultTemplate in WebHookHandler
  3. Set Content-Type header to "application/json" if default template is used.
  4. Handle unsuccessful response code

Fixes #2371

@buger buger merged commit 36848bf into master Jul 10, 2019
@buger buger deleted the fix_webhook branch July 10, 2019 18:11
buger pushed a commit that referenced this pull request Jul 10, 2019
@komalsukhani @buger
Fix webhook (#2372)
f7908c5 
1. Added Timeout to HTTP client used for sending a request to webhook
2. Added new flag `useDefaultTemplate` in WebHookHandler
3. Set Content-Type header to "application/json" if default template is used.
4. Handle unsuccessful response code

 Fixes #2371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content-type header is not set while sending request to webhook
2 participants
@komalsukhani @buger