Validate API specs before loading them #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds validation checks before loading, only tcp spec check is implemented to ensure listening port is provided to avod crashing the gateway. Other checks can be added in different PR as it is beyond the scope of this PR Fixes TykTechnologies#2511
gernest
force-pushed
the
fix/issue-2511
branch
from
bd44fbd
to
2e17f27
Compare
adelowo
approved these changes
Sep 18, 2019
|
/release to release-2.9 |
|
Working on it! Note that it can take a few minutes. |
|
Still working... |
|
@buger Succesfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds validation checks before loading, only tcp spec check
is implemented to ensure listening port is provided to avod
crashing the gateway.
Other checks can be added in different PR as it is beyond the scope
of this PR
Fixes #2511
Fixes #2480