Circuit breaker improvement #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buger
reviewed
Nov 7, 2019
| t.Run("Extended Paths", func(t *testing.T) { | ||
| BuildAndLoadAPI(func(spec *APISpec) { | ||
| UpdateAPIVersion(spec, "v1", func(v *apidef.VersionInfo) { | ||
| json.Unmarshal([]byte(`[ |
|
Apart from small formatting issue looks goood |
tbuchaillot
force-pushed
the
circuit-breaker-improvement
branch
from
23ddc95
to
feaf7af
Compare
|
/release to release-2.9 |
|
Working on it! Note that it can take a few minutes. |
|
Still working... |
tykbot bot
pushed a commit
that referenced
this pull request
Nov 13, 2019
Tyk's Circuit Breaker only works for 500 errors. This is pretty limiting. e.g. the breaker will not trip for failed upstreams. This PR fixes that in order to break the circuit for any 5XX errors or if RoundTrip returns an error. (cherry picked from commit f6d25e6)
|
@furkansenharputlu Succesfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tyk's Circuit Breaker only works for 500 errors. This is pretty limiting. e.g. the breaker will not trip for failed upstreams.
This PR fixes that in order to break the circuit for any 5XX errors or if RoundTrip returns an error.