New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fix #2978
Conversation
This PR also contains a fix for https://github.com/TykTechnologies/tyk-analytics/issues/1815 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
out = append(out, strings.TrimPrefix(key, "raw-")) | ||
} | ||
|
||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to remove this block and make "if exists" return earlier:
if exists && prefix != "" {
// ...
return out
}
keys := c.storage.GetKeys("raw-" + prefix + "*")
// ...
return out
/release to release-2.10 |
Working on it! Note that it can take a few minutes. |
Fix some test in order to stabilize master tests. (cherry picked from commit 2f32536)
@buger Succesfully merged |
Fix some test in order to stabilize master tests.