plugin-compiler: use a dynamic package path #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/release to release-2.10 |
|
/release to release-2.9 |
|
Working on it! Note that it can take a few minutes. |
1 similar comment
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Jul 9, 2020
Workaround for #3195. To test this without having to rebuild the `tyk-plugin-compiler` image, the `build.sh` can be replaced on runtime using the volume flag: ``` $ docker run --rm -v `pwd`/build.sh:/build.sh -v `pwd`:/plugin-source tykio/tyk-plugin-compiler:v2.9.4.2 plugin1.so ``` With this fix, the scenario described in the original ticket will perform as expected, allowing the usage of multiple Docker-built Go plugins. (cherry picked from commit b638cf3)
|
@buger Succesfully merged |
|
@buger Seems like there is conflict and it require manual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #3195.
To test this without having to rebuild the
tyk-plugin-compilerimage, thebuild.shcan be replaced on runtime using the volume flag:With this fix, the scenario described in the original ticket will perform as expected, allowing the usage of multiple Docker-built Go plugins.