[TT-1475] respect ignored paths in CoProcessMiddleware #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is initial test for checking if we have ingore plugin enabled
matiasinsaurralde
approved these changes
Feb 5, 2021
|
/release to release-3 |
|
Working on it! Note that it can take a few minutes. |
|
@matiasinsaurralde Succesfully merged |
tykbot bot
pushed a commit
that referenced
this pull request
Feb 16, 2021
* respect ignored paths in CoProcessMiddleware * add TestGRPCIgnore This is initial test for checking if we have ingore plugin enabled * check ignore on HookType_CustomKeyCheck (cherry picked from commit 8650e18)
|
/release to release-3-lts |
|
Working on it! Note that it can take a few minutes. |
tykbot bot
pushed a commit
that referenced
this pull request
Feb 16, 2021
* respect ignored paths in CoProcessMiddleware * add TestGRPCIgnore This is initial test for checking if we have ingore plugin enabled * check ignore on HookType_CustomKeyCheck (cherry picked from commit 8650e18)
|
@matiasinsaurralde Succesfully merged |
|
/release to release-3.2 |
|
Working on it! Note that it can take a few minutes. |
|
@gregdelhon Seems like there is conflict and it require manual merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check before we process request with coprocess middleware to ensure we skip the middleware when we have
StatusOkAndIgnoreset in context.Related Issue
fixes #3383
Motivation and Context
If you have coprocess set and ignore extended paths. Then the ignored extended paths won't be respected.
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
Checklist
fork, don't request your
master!masterbranch (left side). Also, you should startyour branch off our latest
master.go mod tidy && go mod vendorgo fmt -sgo vet