[TT-657] Move CORS handler from chain to middleware to cover oauth2 endpoints #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsergiy
approved these changes
Feb 18, 2021
|
/release to release-3 |
|
/release to release-3-lts |
|
/release to release-3.1 |
|
Working on it! Note that it can take a few minutes. |
|
@furkansenharputlu Succesfully merged |
|
Working on it! Note that it can take a few minutes. |
|
@furkansenharputlu Succesfully merged |
|
/release to release-3.1 |
|
Working on it! Note that it can take a few minutes. |
|
@furkansenharputlu Succesfully merged |
|
/release to release-3.2 |
|
Working on it! Note that it can take a few minutes. |
|
@furkansenharputlu Succesfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for the move is that the oauth2 handlers don't have a chain in front of it but CORS is in the chain and it is the reason of why oauth endpoints don't support CORS. This PR moves it to routers middleware level to cover all endpoints in an API router.