Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bidirectional streaming for grpc #3602

Merged
merged 8 commits into from
Jul 5, 2021
Merged

fix bidirectional streaming for grpc #3602

merged 8 commits into from
Jul 5, 2021

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented Jun 28, 2021

Description

Fix grpc bidirectional streaming functionality

Related Issue

https://tyktech.atlassian.net/browse/TT-2693

Motivation and Context

fix https://tyktech.atlassian.net/browse/TT-2693

How This Has Been Tested

The same as reported in the ticket

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@github-actions

This comment has been minimized.

Sign in to view
@buger
Copy link
Member

buger commented Jun 28, 2021

Any ideas why tests fail?

@sredxny
Copy link
Contributor Author

sredxny commented Jun 28, 2021

@buger something with goreleaser, I go this message:

 release failed after 202.34s error=invalid nfpm config: cannot add coprocess/bindings/python/coprocess_return_overrides_pb2.py because coprocess/python/proto/coprocess_return_overrides_pb2.py is already present at the same destination (/opt/tyk-gateway/coprocess/python/proto/coprocess_return_overrides_pb2.py): content collision
Error: Process completed with exit code 1.

Not sure what does that means 👀 but the unit test are passing

@buger
Copy link
Member

buger commented Jun 28, 2021

Do not think it is related to goreleaser, but I have no idea why this GH comment about failed test is there.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@sredxny
Copy link
Contributor Author

sredxny commented Jul 2, 2021 •
edited

At this point all the tests passed, but I noticed some unstability on TestReloadLoop tests...from time to time they just fail

@buger buger merged commit c30e12d into master Jul 5, 2021
@buger buger deleted the TT-2693-fix-grpc-bidirectional-streaming branch July 5, 2021 14:52
@buger
Copy link
Member

buger commented Jul 5, 2021

/release to release-3

1 similar comment
@buger
Copy link
Member

buger commented Jul 5, 2021

/release to release-3

@tykbot
Copy link

tykbot bot commented Jul 5, 2021

Working on it! Note that it can take a few minutes.

@buger
Copy link
Member

buger commented Jul 5, 2021

/release to release-3.2

@tykbot
Copy link

tykbot bot commented Jul 5, 2021

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Jul 5, 2021
@sredxny
fix bidirectional streaming for grpc (#3602)
70c5429 
<!-- Provide a general summary of your changes in the Title above -->

## Description
Fix grpc bidirectional streaming functionality

## Related Issue
https://tyktech.atlassian.net/browse/TT-2693

## Motivation and Context
fix https://tyktech.atlassian.net/browse/TT-2693

## How This Has Been Tested
The same as reported in the ticket

## Screenshots (if appropriate)

## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes that apply -->
<!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
- [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
      fork, don't request your `master`!
- [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start
      *your branch* off *our latest `master`*.
- [ ] My change requires a change to the documentation.
  - [ ] If you've changed APIs, describe what needs to be updated in the documentation.
  - [ ] If new config option added, ensure that it can be set via ENV variable
- [ ] I have updated the documentation accordingly.
- [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor`
- [ ] When updating library version must provide reason/explanation for this update.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] Check your code additions will not fail linting checks:
  - [ ] `go fmt -s`
  - [ ] `go vet`

(cherry picked from commit c30e12d)
@tykbot
Copy link

tykbot bot commented Jul 5, 2021

@buger Succesfully merged c30e12db4772163e8f45c6fc2db55f6838787ee7 to release-3 branch.

tykbot bot pushed a commit that referenced this pull request Jul 5, 2021
@sredxny
fix bidirectional streaming for grpc (#3602)
60e730c 
<!-- Provide a general summary of your changes in the Title above -->

## Description
Fix grpc bidirectional streaming functionality

## Related Issue
https://tyktech.atlassian.net/browse/TT-2693

## Motivation and Context
fix https://tyktech.atlassian.net/browse/TT-2693

## How This Has Been Tested
The same as reported in the ticket

## Screenshots (if appropriate)

## Types of changes
<!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality)

## Checklist
<!-- Go over all the following points, and put an `x` in all the boxes that apply -->
<!-- If you're unsure about any of these, don't hesitate to ask; we're here to help! -->
- [ ] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side). If pulling from your own
      fork, don't request your `master`!
- [ ] Make sure you are making a pull request against the **`master` branch** (left side). Also, you should start
      *your branch* off *our latest `master`*.
- [ ] My change requires a change to the documentation.
  - [ ] If you've changed APIs, describe what needs to be updated in the documentation.
  - [ ] If new config option added, ensure that it can be set via ENV variable
- [ ] I have updated the documentation accordingly.
- [ ] Modules and vendor dependencies have been updated; run `go mod tidy && go mod vendor`
- [ ] When updating library version must provide reason/explanation for this update.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.
- [ ] Check your code additions will not fail linting checks:
  - [ ] `go fmt -s`
  - [ ] `go vet`

(cherry picked from commit c30e12d)
@tykbot
Copy link

tykbot bot commented Jul 5, 2021

@buger Succesfully merged c30e12db4772163e8f45c6fc2db55f6838787ee7 to release-3.2 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buger buger Awaiting requested review from buger

@tbuchaillot tbuchaillot Awaiting requested review from tbuchaillot

@matiasinsaurralde matiasinsaurralde Awaiting requested review from matiasinsaurralde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sredxny @buger