Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-2867] Fix ResetQuota calling inside handleDeleteKey function #3619

Merged
merged 3 commits into from
Jul 9, 2021

Conversation

furkansenharputlu
Copy link
Member

The session given to ResetQuota is empty. So, it prevents calling allowance scoped quota counters to remain same.

Copy link
Contributor

@sredxny sredxny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great job 🚀

@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 9, 2021
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 9, 2021
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 9, 2021
@TykTechnologies TykTechnologies deleted a comment from github-actions bot Jul 9, 2021
@buger buger merged commit a780982 into master Jul 9, 2021
@buger buger deleted the fix-handle-delete-key branch July 9, 2021 14:40
@furkansenharputlu
Copy link
Member Author

/release to release-3

@furkansenharputlu
Copy link
Member Author

/release to release-3.0.7

@tykbot
Copy link

tykbot bot commented Jul 9, 2021

Working on it! Note that it can take a few minutes.

@furkansenharputlu
Copy link
Member Author

/release to release-3-lts

@tykbot
Copy link

tykbot bot commented Jul 9, 2021

@furkansenharputlu Seems like there is conflict and it require manual merge.

@tykbot
Copy link

tykbot bot commented Jul 9, 2021

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Jul 9, 2021

@furkansenharputlu Seems like there is conflict and it require manual merge.

@tykbot
Copy link

tykbot bot commented Jul 9, 2021

Working on it! Note that it can take a few minutes.

@tykbot
Copy link

tykbot bot commented Jul 9, 2021

@furkansenharputlu Seems like there is conflict and it require manual merge.

furkansenharputlu added a commit that referenced this pull request Jul 9, 2021
The session given to `ResetQuota` is empty. So, it prevents calling allowance scoped quota counters to remain same.
furkansenharputlu added a commit that referenced this pull request Jul 9, 2021
The session given to `ResetQuota` is empty. So, it prevents calling allowance scoped quota counters to remain same.
furkansenharputlu added a commit that referenced this pull request Jul 9, 2021
The session given to `ResetQuota` is empty. So, it prevents calling allowance scoped quota counters to remain same.
furkansenharputlu added a commit that referenced this pull request Jul 9, 2021
The session given to `ResetQuota` is empty. So, it prevents calling allowance scoped quota counters to remain same.
@furkansenharputlu
Copy link
Member Author

Merged manually to:

  • release-3
  • release-3-lts
  • release-3.0.7
  • release-3.2

@maciejwojciechowski
Copy link
Contributor

@furkansenharputlu what about release-3.2.2 ?

furkansenharputlu added a commit that referenced this pull request Jul 12, 2021
The session given to `ResetQuota` is empty. So, it prevents calling allowance scoped quota counters to remain same.
@furkansenharputlu
Copy link
Member Author

Merged to release-3.2.2 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants