Merging to release-4-lts: [TT-10189/TT-10467] Add OAuthPurgeLapsedTokens (#5766) #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Provide a general summary of your changes in the Title above --> This PR adds an event `OAuthPurgeLapsedTokens`, which upon receiving would delete all lapsed OAuth tokens. It also adds endpoint `DELETE /tyk/oauth/tokens?scope=lapsed` to purge lapsed OAuth tokens synchronously. What are lapsed OAuth tokens? Lapsed OAuth tokens that are expired and past `oauth_token_expired_retain_period` configured in gateway config. Sub Task: https://tyktech.atlassian.net/browse/TT-10467 Parent Ticket: https://tyktech.atlassian.net/browse/TT-10189 <!-- Why is this change required? What problem does it solve? --> <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why --------- Co-authored-by: dcs3spp <dcs3spp@users.noreply.github.com> (cherry picked from commit 6373930)
Apply Sweep Rules to your PR?
|
|
API tests result: skipped 🚫 |
|
API tests result: skipped 🚫 |
|
API tests result: skipped 🚫 |
|
API tests result: skipped 🚫 |
|
API tests result: skipped 🚫 |
jeffy-mathew
deleted the
merge/release-4-lts/63739304403cdb1a0aea18fa5550c7bd5537d954
branch
|
API tests result: skipped 🚫 [TT-10189/TT-10467] Add OAuthPurgeLapsedTokens (#5766) DescriptionThis PR adds an event Related IssueSub Task: https://tyktech.atlassian.net/browse/TT-10467 Motivation and ContextHow This Has Been TestedScreenshots (if appropriate)Types of changes
Checklist
Co-authored-by: dcs3spp dcs3spp@users.noreply.github.com Co-authored-by: Jeffy Mathew jeffy.mathew100@gmail.com |
lghiur
pushed a commit
that referenced
this pull request
Jan 22, 2024
…ens (#5766) (#5901) [TT-10189/TT-10467] Add OAuthPurgeLapsedTokens (#5766) <!-- Provide a general summary of your changes in the Title above --> ## Description This PR adds an event `OAuthPurgeLapsedTokens`, which upon receiving would delete all lapsed OAuth tokens. It also adds endpoint `DELETE /tyk/oauth/tokens?scope=lapsed` to purge lapsed OAuth tokens synchronously. What are lapsed OAuth tokens? Lapsed OAuth tokens that are expired and past `oauth_token_expired_retain_period` configured in gateway config. ## Related Issue Sub Task: https://tyktech.atlassian.net/browse/TT-10467 Parent Ticket: https://tyktech.atlassian.net/browse/TT-10189 ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why --------- Co-authored-by: dcs3spp <dcs3spp@users.noreply.github.com> --------- Co-authored-by: Jeffy Mathew <jeffy.mathew100@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TT-10189/TT-10467] Add OAuthPurgeLapsedTokens (#5766)
Description
This PR adds an event
OAuthPurgeLapsedTokens, which upon receivingwould delete all lapsed OAuth tokens.
It also adds endpoint
DELETE /tyk/oauth/tokens?scope=lapsedto purgelapsed OAuth tokens synchronously.
What are lapsed OAuth tokens? Lapsed OAuth tokens that are expired and
past
oauth_token_expired_retain_periodconfigured in gateway config.Related Issue
Sub Task: https://tyktech.atlassian.net/browse/TT-10467
Parent Ticket: https://tyktech.atlassian.net/browse/TT-10189
Motivation and Context
How This Has Been Tested
Screenshots (if appropriate)
Types of changes
functionality to change)
coverage to functionality)
Checklist
why it's required
explained why
Co-authored-by: dcs3spp dcs3spp@users.noreply.github.com