Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-12425] update gorilla/websocket #6361

Closed
wants to merge 1 commit into from

Conversation

jeffy-mathew
Copy link
Contributor

@jeffy-mathew jeffy-mathew commented Jun 20, 2024

User description

Description

update gorilla/websocket

Related Issue

https://tyktech.atlassian.net/browse/TT-12425

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

PR Type

dependencies


Description

  • Updated github.com/gorilla/websocket dependency from v1.5.2 to v1.5.3 in go.mod.
  • Updated checksum entries in go.sum to reflect the version change of github.com/gorilla/websocket.

Changes walkthrough 📝

Relevant files
Dependencies
go.mod
Update gorilla/websocket dependency version in go.mod       

go.mod

  • Updated github.com/gorilla/websocket dependency from v1.5.2 to v1.5.3.

  • +1/-1     
    go.sum
    Update checksum for gorilla/websocket in go.sum                   

    go.sum

  • Updated checksum entries for github.com/gorilla/websocket to reflect
    version change from v1.5.2 to v1.5.3.
  • +2/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @github-actions github-actions bot added dependencies Pull requests that update a dependency file Review effort [1-5]: 1 labels Jun 20, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    Copy link
    Contributor

    API Changes

    no api changes detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Security
    Ensure the integrity and correctness of the new module checksums

    Confirm that the checksums for github.com/gorilla/websocket v1.5.3 are correct by
    verifying them against an official source or by running go mod tidy to ensure the
    integrity of the module.

    go.sum [304-305]

    +github.com/gorilla/websocket v1.5.3 h1:saDtZ6Pbx/0u+bgYQ3q96pZgCzfhKXGPqt7kZ72aNNg=
    +github.com/gorilla/websocket v1.5.3/go.mod h1:YR8l580nyteQvAITg2hZ9XVh4b55+EU/adAjf1fMHhE=
     
    -
    Suggestion importance[1-10]: 9

    Why: Verifying the integrity of module checksums is essential for security and reliability. This suggestion addresses a critical aspect of dependency management and helps prevent issues related to tampered or corrupted modules.

    9
    Possible issue
    Verify compatibility and absence of breaking changes with the updated library version

    Ensure that the updated version of github.com/gorilla/websocket is compatible with other
    dependencies and does not introduce breaking changes. It's recommended to run integration
    tests and check the release notes of the library for potential breaking changes or new
    features that might affect the current project.

    go.mod [41]

    +github.com/gorilla/websocket v1.5.3
     
    -
    Suggestion importance[1-10]: 8

    Why: Ensuring compatibility and checking for breaking changes when updating a library version is crucial to maintain the stability of the project. This suggestion is important for preventing potential issues that could arise from the update.

    8

    @jeffy-mathew jeffy-mathew marked this pull request as draft June 20, 2024 09:28
    Copy link
    Contributor

    💥 CI tests failed 🙈

    git-state

    all ok

    Please look at the run or in the Checks tab.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    dependencies Pull requests that update a dependency file Review effort [1-5]: 1
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    None yet

    1 participant