feat: Custom Blocks #191
Merged
feat: Custom Blocks #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustom-formattingtoolbar
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
May 25, 2023
YousefED
reviewed
May 25, 2023
YousefED
reviewed
May 30, 2023
This was referenced May 30, 2023
* Fixed custom block placeholders, formatting toolbar, and sizing * Small styling changes * Made text align button not show up when selected block/s doesn't/don't support the prop * Updated docs * Finished 1st draft custom block docs and demo * Added type arguments in custom block docs & minor changes * Implemented PR feedback
YousefED
reviewed
May 30, 2023
| // let complexHTML: string; | ||
| // let complexMarkdown: string; | ||
|
|
||
| function removeInlineContentClass(html: string) { | ||
| return html.replace(/ class="_inlineContent_1c48ad"/g, ""); |
There was a problem hiding this comment.
1c48ad is not stable I think? that will change based on the build
| @@ -38,7 +38,6 @@ Tippy popups that are appended to document.body directly | |||
| .defaultStyles h3, | |||
| .defaultStyles li { | |||
| all: unset !important; | |||
| flex-grow: 1 !important; | |||
There was a problem hiding this comment.
this is intended to be removed right? I thought we just added it
* update packages incl prosemirror-view * fix build * fix ReactAlert + add logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables users to add Custom Blocks! 🥳
See https://www.blocknotejs.org/docs/block-types#custom-block-types
Besides the API surface, the biggest change was rearchitecting BlockNote for custom schemas without compromising on Type-safety. A BlockNote editor will now have a specific type (using generics) based on the Schema (the blocks registered to it).
Two remaining issues will be picked up separately:
(see also #164)