Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draghandle menu on click #21

Merged
merged 11 commits into from Mar 21, 2022
Merged

draghandle menu on click #21

merged 11 commits into from Mar 21, 2022

Conversation

YousefED
Copy link
Collaborator

@YousefED YousefED commented Mar 9, 2022

This adds a menu when clicking the draghandle, partially fixes #16

TODO:

  • implement delete operation

@vercel
Copy link

vercel bot commented Mar 9, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/yousefed/blocknote/86tc8oAU37TBoQLWPpGFRKxLQoFx
✅ Preview: https://blocknote-git-draghandle-menu-yousefed.vercel.app

@YousefED YousefED mentioned this pull request Mar 9, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 9, 2022 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@YousefED
Copy link
Collaborator Author

YousefED commented Mar 9, 2022

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Mar 9, 2022
@github-actions
@YousefED has signed the CLA from Pull Request #21
03c8aff
YousefED
YousefED commented Mar 17, 2022
View reviewed changes
Copy link
Collaborator Author

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! let's add a pw test and then good to merge :)

@17Amir17 17Amir17 merged commit afed2c7 into main Mar 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DragHandle menu
2 participants
@YousefED @17Amir17