Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashmenu work #22

Merged
merged 60 commits into from
Mar 17, 2022
Merged

Slashmenu work #22

merged 60 commits into from
Mar 17, 2022

Conversation

17Amir17
Copy link
Collaborator

@17Amir17 17Amir17 commented Mar 9, 2022

  • Implement the actions (make sure new blocks are created when selecting an option)
  • Show correct keyboard shortcuts for actions
  • Test with playwright

Note: In this pull request I changed the way setBlockHeading works, which fixes an issue with the heading being set for all blocks that contain the selected block (for both slash and bubble menus) see the issue below:
Before
ezgif-4-448d379eee
After
ezgif com-gif-maker

@vercel
Copy link

vercel bot commented Mar 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/yousefed/blocknote/GuQ33frCmpxR4dydWccaSgCzyM3N
✅ Preview: https://blocknote-git-slashmenu-additions-yousefed.vercel.app

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See some comments inline. My main feedback is is that the slash menu should insert new blocks (a sibling below the current block) instead of modify the current block. See notion as example

@17Amir17
Copy link
Collaborator Author

Great! Some small comments :)

Could you add lists and numbered lists as well?

I've added them however, I didn't implement the keyboard shortcuts yet because I want to use commands I create in the bubblemenu-dropdown branch (I still have to change the commands).

@17Amir17 17Amir17 requested a review from YousefED March 14, 2022 15:02
Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, but then I think we're ready to merge this!

packages/core/src/extensions/Blocks/nodes/Block.ts Outdated Show resolved Hide resolved
@17Amir17 17Amir17 merged commit 5cb17da into project/slashmenu Mar 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants