-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slashmenu work #22
Slashmenu work #22
Conversation
refactored setBlockHeading to use findBlock function
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/yousefed/blocknote/GuQ33frCmpxR4dydWccaSgCzyM3N |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See some comments inline. My main feedback is is that the slash menu should insert new blocks (a sibling below the current block) instead of modify the current block. See notion as example
packages/core/src/extensions/SlashMenu/CommandChains/headingChain.ts
Outdated
Show resolved
Hide resolved
I've added them however, I didn't implement the keyboard shortcuts yet because I want to use commands I create in the bubblemenu-dropdown branch (I still have to change the commands). |
Project/Bubblemenu dropdown
fix bubblemenu loop bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment, but then I think we're ready to merge this!
Project/Added indent options to BubbleMenu
Note: In this pull request I changed the way setBlockHeading works, which fixes an issue with the heading being set for all blocks that contain the selected block (for both slash and bubble menus) see the issue below:
![ezgif-4-448d379eee](https://user-images.githubusercontent.com/36531255/157504418-d69729f0-30be-4f90-8638-072072437d88.gif)
![ezgif com-gif-maker](https://user-images.githubusercontent.com/36531255/157505033-bd364f05-dc2a-40bb-b0a4-c02d3e0335a9.gif)
Before
After