Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error when custom blocks are in initialContent #348

Merged
merged 8 commits into from
Oct 3, 2023

Conversation

matthewlipski
Copy link
Collaborator

@matthewlipski matthewlipski commented Sep 26, 2023

This PR fixes an error that's thrown when custom blocks are present in teh initialContent editor option, as they are rendered before the TipTap editor is initialized.

@vercel
Copy link

vercel bot commented Sep 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote-website ✅ Ready (Inspect) Visit Preview Oct 3, 2023 4:06pm

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work and be safe for collaboration as well (might be good to double check).

Seems it's causing an issue with the snapshots though

@matthewlipski matthewlipski merged commit 5dd663c into main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants