New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean getitems #579
Merged
YousefED
merged 10 commits into
mentions-suggestions
from
mentions-suggestions-getitems
Feb 15, 2024
Merged
clean getitems #579
YousefED
merged 10 commits into
mentions-suggestions
from
mentions-suggestions-getitems
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…or' into mentions-suggestions-getitems
YousefED
changed the base branch from
mentions-suggestions
to
ui-component-creation-refactor
February 15, 2024 06:31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor comments
packages/react/src/components/SuggestionMenu/DefaultPositionedSuggestionMenu.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/components/SuggestionMenu/DefaultPositionedSuggestionMenu.tsx
Outdated
Show resolved
Hide resolved
…ns-getitems # Conflicts: # packages/react/src/components/SuggestionMenu/DefaultPositionedSuggestionMenu.tsx # packages/react/src/index.ts
YousefED
changed the base branch from
ui-component-creation-refactor
to
mentions-suggestions
February 15, 2024 14:16
58 tasks
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, any type T can be returned from
getItems
, as long as it's also expected by the element passed assuggestionMenuComponent
. When using the default componentMantineSuggestionMenu
, we expectDefaultSuggestionItem
as items.Also:
TODO:
slashMenuItems
API working? (not too much effort I think)