Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mobile fixes #626

Merged
merged 3 commits into from Mar 11, 2024
Merged

docs: Mobile fixes #626

merged 3 commits into from Mar 11, 2024

Conversation

matthewlipski
Copy link
Collaborator

This PR hides the editor below a certain screen size and fixes z-index of hamburger menu

Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 8, 2024 4:30pm
blocknote-website ✅ Ready (Inspect) Visit Preview Mar 8, 2024 4:30pm

Copy link
Collaborator

@YousefED YousefED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you hiding the editor now?

previously we used:

  @media only screen and (hover: none) and (pointer: coarse) {
    display: none; /* disable on mobile */
  }

to disable the editor on touch screen devices

see

@media only screen and (hover: none) and (pointer: coarse) {

@matthewlipski
Copy link
Collaborator Author

How are you hiding the editor now?

previously we used:

  @media only screen and (hover: none) and (pointer: coarse) {
    display: none; /* disable on mobile */
  }

to disable the editor on touch screen devices

see

@media only screen and (hover: none) and (pointer: coarse) {

Fixed, now uses the same query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants