Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formalized Comment inside signature #1143

Closed
Brochato opened this issue Oct 1, 2018 · 0 comments
Closed

Fix formalized Comment inside signature #1143

Brochato opened this issue Oct 1, 2018 · 0 comments
Assignees
@maxime645
Labels
Bug TC-Comment
Milestone
Formalized comment

Comments

@Brochato
Copy link
Contributor

Brochato commented Oct 1, 2018 •
edited

After the changes of #1142, the formalized comments are no longer inside the Identification Division but inside the Procedure Division.
The Signature Generator can no longer see the formalized comment.
We also need a Unit Test about it.
@Brochato Brochato added this to the Formalized comment milestone Oct 1, 2018
@Brochato Brochato self-assigned this Oct 1, 2018
Brochato added a commit that referenced this issue Oct 9, 2018
@Brochato
Issue #1143: fix Signature Generator to work with FormCom & MultCom
a627d9f 
+ Unit Test
@smedilol smedilol assigned maxime645 and unassigned Brochato Nov 12, 2018
maxime645 pushed a commit that referenced this issue Nov 28, 2018
Issue #1143: fix Signature Generator to work with FormCom & MultCom
e757f88
maxime645 pushed a commit that referenced this issue Nov 29, 2018
Issue #1165, #1143, fix unit test output
0d54d5e
maxime645 pushed a commit that referenced this issue Nov 30, 2018
Issue #1165, #1143, fix no EI unit test output
9c0f5f4
maxime645 pushed a commit that referenced this issue Dec 18, 2018
@Brochato
Issue #1143: fix Signature Generator to work with FormCom & MultCom
e2ed22e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxime645 maxime645

Labels
Bug TC-Comment
Projects
None yet
Milestone
Formalized comment
Development

No branches or pull requests
2 participants
@Brochato @maxime645