Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WI #2316 Allow parsing of COPYs containing a PROCEDURE DIVISION #2577

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

fm-117
Copy link
Contributor

@fm-117 fm-117 commented Sep 19, 2023

  • Remove InsideProcedureDivision property from MultilineScanState
    • to parse paragraph or section names properly, use position in text line

This breaks some incremental tests, see #2576, they are ignored in this PR.

This does not solve #2316 as the scan state can still be altered by included documents.

@fm-117 fm-117 requested a review from efr15 September 19, 2023 10:00
@fm-117 fm-117 self-assigned this Sep 19, 2023
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 19, 2023
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 21, 2023
@fm-117 fm-117 merged commit 358d72a into develop Sep 21, 2023
4 checks passed
@fm-117 fm-117 deleted the 2316_ScanParagraphWithoutScanState_Integration branch September 21, 2023 15:37
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Sep 21, 2023
@fm-117 fm-117 mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants