Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WI #2585 Update JSON GENERATE and JSON PARSE for Cobol 6.3 #2590

Merged
merged 8 commits into from
Nov 2, 2023
Merged

WI #2585 Update JSON GENERATE and JSON PARSE for Cobol 6.3 #2590

merged 8 commits into from
Nov 2, 2023

Conversation

efr15
Copy link
Contributor

@efr15 efr15 commented Oct 26, 2023

Fixes #2585

Also includes a small fix for CodeElement (remove useless call to ToString)

@efr15 efr15 added this to the Cobol 5.1 to 6.3 milestone Oct 26, 2023
@efr15 efr15 requested a review from fm-117 October 26, 2023 08:17
@efr15 efr15 self-assigned this Oct 26, 2023
@efr15 efr15 linked an issue Oct 26, 2023 that may be closed by this pull request
Update JSON GENERATE/PARSE statements #2585
Closed
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 26, 2023
fm-117
fm-117 requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@fm-117 fm-117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that all newly created storage areas are correctly captured

TypeCobol/AntlrGrammar/Cobol2002CodeElements.g4 Outdated Show resolved Hide resolved
TypeCobol/AntlrGrammar/Cobol2002CodeElements.g4 Outdated Show resolved Hide resolved
TypeCobol/Compiler/CodeElements/Statement/JsonParseStatement.cs Show resolved Hide resolved
TypeCobol/Compiler/Parser/CodeElementBuilder/CobolStatementsBuilder.cs Outdated Show resolved Hide resolved
TypeCobol/Compiler/Parser/CodeElementBuilder/CobolStatementsBuilder.cs Outdated Show resolved Hide resolved
@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 26, 2023
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Oct 31, 2023
fm-117
fm-117 requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@fm-117 fm-117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • revert the SORT modifications, I think we need to adress them in a separate issue as it is more complex than anticipated

TypeCobol/Compiler/Parser/CodeElementBuilder/CobolExpressionsBuilder.cs Outdated Show resolved Hide resolved
@efr15 efr15 requested a review from fm-117 October 31, 2023 17:20
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 2, 2023
@efr15 efr15 merged commit 6423cb1 into develop Nov 2, 2023
4 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Nov 2, 2023
@fm-117 fm-117 mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm-117 fm-117 fm-117 approved these changes

Assignees

@efr15 efr15

Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
Cobol 5.1 to 6.3
Development

Successfully merging this pull request may close these issues.

Update JSON GENERATE/PARSE statements
2 participants
@efr15 @fm-117