Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24: Support for Sql Server dialect #25

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Fixes #24: Support for Sql Server dialect #25

merged 3 commits into from
Jan 30, 2024

Conversation

cam-m
Copy link
Contributor

@cam-m cam-m commented Jan 18, 2024

  • Double quoted and Bracketed strings parsed as Quoted Identifiers
  • Double quotes no longer parsed as literals

- Double quoted and Bracketed strings parsed as Quoted Identifiers
- Double quotes no longer parsed as literals
@Lotes
Copy link
Collaborator

Lotes commented Jan 23, 2024

@cam-m Do you need a new release of LangiumSQL? If so, we should increment the version in the package.json.

@cam-m
Copy link
Contributor Author

cam-m commented Jan 23, 2024

@Lotes a new release would be great - do you have a separate process for bumping version and publishing to npm?

@Lotes
Copy link
Collaborator

Lotes commented Jan 24, 2024

@cam-m Nope, I normally do this manually. If you have any recommendation, just speak :)... I am not so familiar with auto-versioning. For the moment, a manual increment should be sufficient. I think "2.5" is next. Update it in all package.jsons.

@cam-m
Copy link
Contributor Author

cam-m commented Jan 24, 2024

@cam-m Nope, I normally do this manually. If you have any recommendation, just speak :)... I am not so familiar with auto-versioning. For the moment, a manual increment should be sufficient. I think "2.5" is next. Update it in all package.jsons.

Cool, I've bumped the patch versions as follows:

  • langium-sql to 0.2.4
  • langium-sql-vscode to 0.0.5

@Lotes
Copy link
Collaborator

Lotes commented Jan 29, 2024

I think you need a npm install after the bump to have the right numbers in the lock file. I can do this now. Sorry for making you wait.

EDIT, sorry I saw it is your forked repo. So please commit the lock file after an npm I.

 - committing package.lock for new patch version.
@cam-m
Copy link
Contributor Author

cam-m commented Jan 29, 2024

@Lotes no problems, sorry i missed that. done now

@Lotes Lotes merged commit 4568c54 into TypeFox:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants