Wrapper: Separate service configuration and init

TypeFox · Nov 10, 2023 · 8c6d819 · 8c6d819
1 parent 69a3212
commit 8c6d819
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/monaco-editor-wrapper/src/wrapper.ts b/packages/monaco-editor-wrapper/src/wrapper.ts
@@ -53,7 +53,9 @@ export class MonacoEditorLanguageClientWrapper {
         } else {
             this.editorApp = new EditorAppExtended(this.id, userConfig, this.logger);
         }
+
         // editorApps init their own service thats why they have to be created first
+        this.configureServices();
         await this.initServices();
 
         this.languageClientWrapper.init(this.editorApp.getConfig().languageId,
@@ -62,10 +64,10 @@ export class MonacoEditorLanguageClientWrapper {
         this.initDone = true;
     }
 
-    private async initServices() {
-        // always set required services if not configure
+    protected configureServices() {
+        // always set required services if not configured
         this.serviceConfig.userServices = this.serviceConfig.userServices ?? {};
-        const configureService = this.serviceConfig.userServices.configure;
+        const configureService = this.serviceConfig.userServices.configure ?? undefined;
 
         if (!configureService) {
             const mlcDefautServices = {
@@ -77,7 +79,9 @@ export class MonacoEditorLanguageClientWrapper {
 
         // overrule debug log flag
         this.serviceConfig.debugLogging = this.logger.isEnabled() && (this.serviceConfig.debugLogging || this.logger.isDebugEnabled());
+    }
 
+    protected async initServices() {
         if (wasVscodeApiInitialized()) {
             this.logger.debug('No service init on restart', this.serviceConfig.debugLogging);
         } else {