Merge pull request #670 from TypeFox/wrapper-everything-optional

Wrapper: Make codeResources and useDiffEditor optional in EditorAppConfig

.eslintrc.cjs

@@ -16,7 +16,8 @@ module.exports = {
     ],
     parserOptions: {
         ecmaVersion: 2022,
-        sourceType: 'module'
+        sourceType: 'module',
+        project: ['./tsconfig.json']
     },
     plugins: [
         '@typescript-eslint',
@@ -80,6 +81,8 @@ module.exports = {
         '@typescript-eslint/prefer-for-of': 'error',                // prefer for-of loop over arrays
         '@typescript-eslint/prefer-namespace-keyword': 'error',     // prefer namespace over module in TypeScript
         '@typescript-eslint/triple-slash-reference': 'error',       // ban /// <reference />, prefer imports
-        '@typescript-eslint/type-annotation-spacing': 'error'       // consistent space around colon ':'
+        '@typescript-eslint/type-annotation-spacing': 'error',      // consistent space around colon ':'
+        '@typescript-eslint/strict-boolean-expressions': 'error',   // Disallow certain types in boolean expressions
+        '@typescript-eslint/no-unnecessary-condition': 'error'      // Disallow conditionals where the type is always truthy or always falsy
     }
 };

.github/workflows/actions.yml

@@ -18,10 +18,10 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v4
-    - name: Use Node.js
-      uses: actions/setup-node@v4
-      with:
-        node-version: '20'
+
+    - name: Volta
+      uses: volta-cli/action@v4
+
     - name: Use pnpm
       uses: pnpm/action-setup@v3
       with:
@@ -32,19 +32,22 @@ jobs:
       run: |
         npm ci
 
-    - name: Lint
+    - name: Build
       shell: bash
       run: |
-        npm run lint
+        npm run report:versions
+        npm run build
 
-    - name: Build
+    - name: Lint
       shell: bash
       run: |
-        npm run build
+        npm run report:versions
+        npm run lint
 
     - name: Test
       shell: bash
       run: |
+        npm run report:versions
         npm run test:run
 
     - name: Build production