Implemented changes from first review feedback

TypeFox · Apr 6, 2022 · 2c0102c · 2c0102c
1 parent dadde1b
commit 2c0102c
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 34 deletions.
diff --git a/README.md b/README.md
@@ -24,7 +24,7 @@
 
 ### Project Modernization
 
-From release 0.19.0 onward the project switched to npm workspaces. We no longer require yarn, lerna  and webpack. Mostly therefore we the list of `devDependencies` is substantially shorter. All code has been moved to [./packages](./packages) directory.
+From release 0.19.0 onward the project switched to npm workspaces. We no longer require yarn, lerna and webpack. Mostly therefore the list of `devDependencies` is substantially shorter. All code has been moved to [./packages](./packages) directory.
 
 As before the library code is just compiled with the TypeScript compiler and the library is now packaged with npm. The need for bundling does no longer exist for the example. The compiled code is either executed by node or the web/client related code/pages are served with [vite.js](https://vitejs.dev/).
 

diff --git a/index.html b/index.html
@@ -2,8 +2,9 @@
 <html>
 
 <head>
-    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
-    <meta http-equiv="Content-Type" content="text/html;charset=utf-8">
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>monaco-languageclient Examples</title>
 </head>
 
 <body>

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -35,11 +35,11 @@
     "glob-to-regexp": "^0.4.1",
     "vscode-jsonrpc": "6.0.0",
     "vscode-languageclient": "7.0.0",
-    "vscode-languageserver-textdocument": "^1.0.4",
-    "vscode-uri": "^3.0.3"
+    "vscode-languageserver-textdocument": "1.0.4",
+    "vscode-uri": "3.0.3"
   },
   "devDependencies": {
-    "@types/vscode": "1.65.0",
+    "@types/vscode": "1.66.0",
     "@types/node": "^16.11.7",
     "@types/glob-to-regexp": "^0.4.1"
   },

diff --git a/packages/examples/browser/package.json b/packages/examples/browser/package.json
@@ -3,8 +3,8 @@
   "name": "browser-example",
   "version": "0.19.0-next.0",
   "dependencies": {
-    "monaco-editor": "^0.33.0",
-    "monaco-editor-workers": "^0.33.0-next.2",
+    "monaco-editor": "0.33.0",
+    "monaco-editor-workers": "0.33.0-next.2",
     "monaco-languageclient": "../../client",
     "vscode-json-languageservice": "^4.2.1"
   },

diff --git a/packages/examples/client/package.json b/packages/examples/client/package.json
@@ -3,8 +3,8 @@
   "private": true,
   "version": "0.19.0-next.0",
   "dependencies": {
-    "monaco-editor": "^0.33.0",
-    "monaco-editor-workers": "^0.33.0-next.2",
+    "monaco-editor": "0.33.0",
+    "monaco-editor-workers": "0.33.0-next.2",
     "monaco-languageclient": "../../client",
     "@codingame/monaco-jsonrpc": "^0.3.1",
     "normalize-url": "^7.0.3"

diff --git a/vite.config.ts b/vite.config.ts
@@ -18,10 +18,9 @@ export default defineConfig({
     build: {
         rollupOptions: {
             input: {
-                client: path.resolve(__dirname, '/packages/examples/client/index.html')
-            },
-            plugins: [
-            ]
+                client: path.resolve(__dirname, '/packages/examples/client/index.html'),
+                browser: path.resolve(__dirname, '/packages/examples/browser/index.html')
+            }
         }
     },
     server: {