Implemented review comments

- Added eslint rules @typescript-eslint/strict-boolean-expressions and @typescript-eslint/no-unnecessary-condition
- Updated dependencies once more

.eslintrc.cjs

@@ -16,7 +16,8 @@ module.exports = {
     ],
     parserOptions: {
         ecmaVersion: 2022,
-        sourceType: 'module'
+        sourceType: 'module',
+        project: ['./tsconfig.json']
     },
     plugins: [
         '@typescript-eslint',
@@ -80,6 +81,8 @@ module.exports = {
         '@typescript-eslint/prefer-for-of': 'error',                // prefer for-of loop over arrays
         '@typescript-eslint/prefer-namespace-keyword': 'error',     // prefer namespace over module in TypeScript
         '@typescript-eslint/triple-slash-reference': 'error',       // ban /// <reference />, prefer imports
-        '@typescript-eslint/type-annotation-spacing': 'error'       // consistent space around colon ':'
+        '@typescript-eslint/type-annotation-spacing': 'error',      // consistent space around colon ':'
+        '@typescript-eslint/strict-boolean-expressions': 'error',   // Disallow certain types in boolean expressions
+        '@typescript-eslint/no-unnecessary-condition': 'error'      // Disallow conditionals where the type is always truthy or always falsy
     }
 };

package.json

@@ -5,12 +5,12 @@
     "@codingame/esbuild-import-meta-url-plugin": "~1.0.2",
     "@codingame/monaco-vscode-rollup-vsix-plugin": "~5.2.0",
     "@rollup/pluginutils": "~5.1.0",
-    "@types/node": "~20.14.0",
+    "@types/node": "~20.14.1",
     "@types/react": "~18.3.3",
     "@types/react-dom": "~18.3.0",
     "@types/vscode": "~1.89.0",
-    "@typescript-eslint/eslint-plugin": "~7.11.0",
-    "@typescript-eslint/parser": "~7.11.0",
+    "@typescript-eslint/eslint-plugin": "~7.12.0",
+    "@typescript-eslint/parser": "~7.12.0",
     "@vitest/browser": "~1.6.0",
     "editorconfig": "~2.0.0",
     "esbuild": "~0.21.4",
@@ -24,7 +24,7 @@
     "vite": "~5.2.12",
     "vitest": "~1.6.0",
     "vite-node": "~1.6.0",
-    "webdriverio": "~8.38.0"
+    "webdriverio": "~8.38.2"
   },
   "volta": {
     "node": "20.14.0",

packages/client/src/index.ts

@@ -20,7 +20,7 @@ export class MonacoLanguageClient extends BaseLanguageClient {
     protected readonly connectionProvider: IConnectionProvider;
 
     constructor({ id, name, clientOptions, connectionProvider }: MonacoLanguageClientOptions) {
-        super(id || name.toLowerCase(), name, clientOptions);
+        super((id ?? 'unknown-id') || name.toLowerCase(), name, clientOptions);
         this.connectionProvider = connectionProvider;
     }