-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to use alternative monaco-editor-core packages #117
Comments
akosyakov
added a commit
that referenced
this issue
Sep 6, 2018
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
added a commit
that referenced
this issue
Sep 6, 2018
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
If I understand this right, shouldn't this be a |
@nikeee hi, I've tried it, but they have 2 drawbacks:
|
Two drawbacks when using a devDependency:
When using a peerDependency, you also get a warning when the required package is not installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The last release of Monaco broke Theia, since they removed unused code which is used by Theia. For Theia we are going to publish an alternative package to monaco-editor-core with needed code. Here, we are going to remove runtime dependency and the client will be responsible to provide Monaco.
The text was updated successfully, but these errors were encountered: