Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use alternative monaco-editor-core packages #117

Closed
akosyakov opened this issue Sep 6, 2018 · 3 comments
Closed

Allow to use alternative monaco-editor-core packages #117

akosyakov opened this issue Sep 6, 2018 · 3 comments
Assignees

Comments

@akosyakov
Copy link
Contributor

The last release of Monaco broke Theia, since they removed unused code which is used by Theia. For Theia we are going to publish an alternative package to monaco-editor-core with needed code. Here, we are going to remove runtime dependency and the client will be responsible to provide Monaco.

@akosyakov akosyakov self-assigned this Sep 6, 2018
akosyakov added a commit that referenced this issue Sep 6, 2018
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Sep 6, 2018
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@nikeee
Copy link

nikeee commented Sep 20, 2018

If I understand this right, shouldn't this be a peerDependency?

@akosyakov
Copy link
Contributor Author

akosyakov commented Sep 20, 2018

@nikeee hi, I've tried it, but they have 2 drawbacks:

  • they don't get installed, so you cannot use their APIs - we obviously need it to use APIs in monaco-languageclient
  • they are required to be installed by a client - we don't want it, we want to install our packages providing APIs similar to monaco-editor-core, e.g. @typefox/monaco-editor-core

@nikeee
Copy link

nikeee commented Dec 2, 2018

Two drawbacks when using a devDependency:

  • You are forced to use the specified version. This may conflict with other libraries used like react-monaco-editor.
  • It only gets installed if you develop this package. When using this library no devDependency is installed.
    See: https://stackoverflow.com/a/22004559

When using a peerDependency, you also get a warning when the required package is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants