-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing dompurify addHook #300
Comments
The latest version is a old version... no active maintainer have the permissions on https://www.npmjs.com/package/monaco-languageclient so the last version is published on https://www.npmjs.com/package/@codingame/monaco-languageclient |
I probably was too vague: I didn't install monaco-languageclient with npm , but checked out the latest master here. Of course it can still have wrong dependencies (attaching package-lock.json ), but which would be the right ones? |
This bug was only impacting the version 0.29.0 of monaco-editor, I guess you can update it. Btw feel free to create a PR or I'll do it when I'll get time. |
Well, it isn't so simple: changing in example/package.json leads to compilation failure:
|
You just seem to have multiple version of monaco-editor-core, your yarn.lock is probably broken, I suggest you remove it and regenerate it |
#301 should fix it |
Well, doesn't that create multiple versions of monaco-editor-core? Now the top-level package.json has
while example/package.json still has
And since @codingame/monaco-languageclient changed, version "^0.14.0" should probably be bumped as well... |
I don't think it was an issue, the example just wasn't up to date. It's updated |
Yes, now it works (or at least no longer crashes so soon :-) ) - thanks a lot! |
I've just checked out the latest version and am trying to run the Node.js example. When building, yarn shows quite few warnings like
That's just a warning, so I ignore it and proceed to run
yarn run start
and open http://localhost:3000/ .That seems to be working - I see the Monaco Language Client Node.js Sample page, and the console has "Sample Language Client: The server is initialized." - but soon (I suppose on any further input from the backend language server) crashes:
So it seems the warning was about something real... I see at https://githubmemory.com/repo/microsoft/monaco-editor/issues/2691 that monaco-editor recently had a suspiciously similar dependency problem - perhaps it should also be fixed in monaco-editor-core?
The text was updated successfully, but these errors were encountered: