Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass options with rootUri to createMonacoServices #31

Closed
akosyakov opened this issue Sep 7, 2017 · 1 comment
Closed

Pass options with rootUri to createMonacoServices #31

akosyakov opened this issue Sep 7, 2017 · 1 comment
Labels
beginners help wanted

Comments

@akosyakov
Copy link
Contributor

createMonacoServices should accept options as the second optional argument to pass rootUri to the workspace service now and additional options in the future

monaco-languageclient/src/services.ts

Line 12 in b901301

export function createMonacoServices(editor: monaco.editor.IStandaloneCodeEditor): BaseLanguageClient.IServices {

@akosyakov akosyakov mentioned this issue Sep 10, 2017
Closed
cdietrich added a commit to cdietrich/monaco-languageclient that referenced this issue Sep 22, 2017
@cdietrich
passing Options to createMonacoServices to allow a rootUri being set T…
5f5fe4f 
…ypeFox#31

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
akosyakov pushed a commit that referenced this issue Sep 22, 2017
@cdietrich @akosyakov
passing Options to createMonacoServices to allow a rootUri being set #31
f0ef95f 


Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@akosyakov
Copy link
Contributor Author

Fixed with #31, thanks @cdietrich

@rcjsuen rcjsuen mentioned this issue Jan 14, 2018
Closed
@rcjsuen rcjsuen mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginners help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov