Bumping to monaco 0.14.2 #107
Conversation
src/monaco-converter.ts
Outdated
| @@ -477,30 +477,33 @@ export class ProtocolToMonacoConverter { | |||
| }; | |||
| } | |||
|
|
|||
| asDocumentSymbolResult(values: SymbolInformation[] | DocumentSymbol[]): monaco.languages.SymbolInformation[] { | |||
| asDocumentSymbolResult(values: SymbolInformation[] | DocumentSymbol[]): monaco.languages.DocumentSymbol[] { | |||
| if (DocumentSymbol.is(values[0])) { | |||
| // FIXME when Monaco supports DocumentSymbol | |||
There was a problem hiding this comment.
@Twinside this is great! Would you be able also to add missing conversion? Now it should be possible. We should do it by analogy with https://github.com/Microsoft/vscode-languageserver-node/blob/7850be5cce4ed39485150969de14947d08c47375/client/src/protocolConverter.ts#L517-L542
|
I've added the missing conversion |
|
@Twinside it looks good, thank you. I would like to test new Monaco with Theia before merging to make sure that there is no any new UI quirks. |
|
@akosyakov any update on your merging tests? Looking forward to getting this PR merged so we can upgrade as well. A bunch of new cool features should be available with that. |
|
Sorry, we don't have time to review and test it now. I've published |
|
Just published v0.8.0 with these changes. |
With adaptation for the changes in the symbol API