align CompletionItemKind with Monaco 0.17.0 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov
requested review from
AlexTugarev,
asual,
BroKun,
gatesn,
mofux and
rcjsuen
as code owners
|
Open in Gitpod - starts a development workspace for this pull request in code review mode and opens it in a browser IDE. |
|
@merzbird Could you give a try with |
9 tasks
|
@akosyakov |
|
@merzbird nope, thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #173: Monaco has more kinds in 0.17.0 breaking a logic of adjusting position by one. This PR maps kinds directly, later, for new versions, we will need to review a mapping.
Published under
devtag for testing in downstream projects.